Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme: Minimal Red #5323

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Add theme: Minimal Red #5323

merged 1 commit into from
Feb 13, 2025

Conversation

AfonsoMiranda02
Copy link
Contributor

@AfonsoMiranda02 AfonsoMiranda02 commented Feb 6, 2025

I am submitting a new Community Plugin

Repo URL

https://github.com/AfonsoMiranda02/Obsidian-MinimalRed

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Feb 6, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 274 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Feb 8, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 274 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei
Copy link
Collaborator

joethei commented Feb 12, 2025

@import url(...
As per our developer policies and guidelines, it's not allowed for themes to load remote resources, the proper way is to embed them as base64.
See this guide: https://docs.obsidian.md/Themes/App+themes/Embed+fonts+and+images+in+your+theme

Obsidian-MinimalRed
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

@joethei joethei self-assigned this Feb 12, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Feb 12, 2025
@AfonsoMiranda02
Copy link
Contributor Author

AfonsoMiranda02 commented Feb 12, 2025

All done
Ps: I didn´t updated my repository link but you can check that i changed it name

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Feb 13, 2025
@joethei joethei merged commit 32d7609 into obsidianmd:master Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants